desihub / specex

DESI spectrograph PSF fitting
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Vector refactor and I/O clean up #42

Closed marcelo-alvarez closed 3 years ago

marcelo-alvarez commented 3 years ago

In anticipation of removing boost dependence on all vector and matrix operations, all instances of harp::vector_double have been replaced by unhrp::vector_double, which is defined locally, and several obsolete I/O functions have been removed, as well those for XML serialization, among other modifications. Results remain bitwise identical and performance is unaffected by these changes.

Please verify it builds as expected before merging.

sbailey commented 3 years ago

Catching up on PRs. Builds as expected; I will trust your tests for bitwise and performance checks. Merging now.