Closed marcelo-alvarez closed 3 years ago
An additional commit compares input PSF properties to those that are specified (either by default or the command line), and only uses the input PSF if they all match; otherwise, it prints a warning message and does not use the input PSF as a starting point.
The performance and behaviour for the case discussed above remain unchanged.
Previous behaviour of specex prevented using input PSF parameters when the Legendre degree was specified with the
--legendre-deg-wave
flag torun_specex
, as is currently the case.Using input PSF parameters when the Legendre degree is specified gives a speedup on cori of about 20-40% for b and z cameras, for arc exposure 00098135 on 20210710, using input consistent with the current trunk of desi_spectro_calib, with respect to using desi environment 21.7e on cori and the current master branch of specex.
Using input PSF parameters also results in output PSF that are nearly identical, differing by
d_psf < 1e-3
for fiber = [4, 495] and wavelength = [3800, 5000, 5600], [6000, 6700, 7300], and [7900, 8700, 9500], for all 10 b, r, and z cameras, respectively, for arc exposure 00098135 on 20210710 (180 PSF comparisons total), withd_psf
defined using:The change in the output PSF for other exposures, fibers, and wavelengths has not been measured, but there is no reason to believe the differences from this change would not be similarly negligible.