search

desihub / specex

DESI spectrograph PSF fitting
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Fixes silent PSF fit fatal error #54

Closed marcelo-alvarez closed 2 years ago

marcelo-alvarez commented 2 years ago

Fixes #53 -- Silent PSF fit fatal error by throwing a std::runtime_error() exception when SPECEX_ERROR() is called.

Verified this solution by hardcoding a call to SPECEX_ERROR when a specific camera string is in the arc preproc exposure image file name and verifying that the PSF for that camera is not written, an error is logged, the rest of the PSFs are written, and the job proceeds normally.

Please verify this is the expected behaviour and merge.

julienguy commented 2 years ago

This is a good solution. Thanks for fixing this issue.