search

desihub / speclite

Lightweight utilities for working with spectroscopic data
14 stars 19 forks source link

Rework transform APIs #21

Closed dkirkby closed 10 months ago

dkirkby commented 8 years ago

This PR is to review the various transform APIs and aim for more consistency and convenience. I am starting with the redshift transform since it is the simplest.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-7.5%) to 92.478% when pulling 32f0a6fc78bd253ee91cc8d325d7e99728a3217b on redshift_api into 573b756f91112a55115f624ad268100cdb7de561 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-7.4%) to 92.564% when pulling e881b213e9153a25864c638d2dd0ec3d39585af8 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.6%) to 97.397% when pulling 36ab3404f417f6ad3a44cb2a9e00dde9b4e2a3c0 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9afc2c6b475bb55f8ab6240b225fbde578d00088 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

dkirkby commented 8 years ago

The redshift API updates (#8) are now complete, although the docs still need some updates. I am going to try using the new utility module to streamline the resampling API next.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.5%) to 99.499% when pulling 8d15735110e1ad607938ae06249e712341722419 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.5%) to 99.5% when pulling 29746719a68937ed79d7e72823ef703578824c52 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.9%) to 97.056% when pulling 88eb98942e5b272c2248690b6d6a353dc3197c10 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.9%) to 97.056% when pulling dddb6cbc29759e69f634895a61a8a352fd3e53a0 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.9%) to 97.056% when pulling e92d2acebf90ff4df9ec0ff56fc9655c2c36198b on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.9%) to 97.056% when pulling 7ea1d54ed065e03e9e02699da5b75b6b1f213ab2 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.9%) to 97.056% when pulling 712ca4ee96b2b95a21a3708abf123e84ffbb7008 on redshift_api into cce9b026494702db52792f44ff47df53ae508c9b on master.

weaverba137 commented 4 years ago

Will this PR ever be merged? If not, can we delete the branch?

dkirkby commented 4 years ago

It will probably never be merged but I would like to keep this branch alive until I get a chance to see what might be worth keeping.

weaverba137 commented 4 years ago

Thanks. Leaving this one open.

weaverba137 commented 10 months ago

@dkirkby have you had a chance to see what might be worth keeping on this branch?

dkirkby commented 10 months ago

I am fine with abandoning the code in this branch now.

weaverba137 commented 10 months ago

OK, thank you, closing.