search

desihub / speclite

Lightweight utilities for working with spectroscopic data
14 stars 19 forks source link

do the filter curves really have the atmosphere included? #39

Closed moustakas closed 2 years ago

moustakas commented 6 years ago

@dkirkby The filters purport to have the atmosphere included https://speclite.readthedocs.io/en/latest/filters.html but, e.g., the SDSS i-band filter appears to be missing the telluric bands around ~7500 A, e.g. https://www.sdss.org/instruments/camera/#Filters

Any thoughts?

dkirkby commented 6 years ago

Good catch @moustakas! I just did a quick check against the tabulated source data and you are right that the atmosphere is not included: sdss

(shaded = w/o atmos., curve = w/ X=1.3 atmos.)

Before I fix this, let me just check that X=1.3 is what you actually want?

moustakas commented 6 years ago

I'm not certain. Let me ask on-list.

moustakas commented 6 years ago

Actually, this issue just affects the SDSS filters, right? So let's just stick with X=1.3. Thanks.

weaverba137 commented 4 years ago

@moustakas, does this issue need to remain open?

moustakas commented 2 years ago

Done in #76.