search

desihub / speclite

Lightweight utilities for working with spectroscopic data
14 stars 19 forks source link

Added Euclid filters #48

Closed fjaviersanchez closed 5 years ago

fjaviersanchez commented 5 years ago

This PR addresses #47. I added the Euclid filters and some documentation.

dkirkby commented 5 years ago

@fjaviersanchez Can you check why the CI tests are failing?

fjaviersanchez commented 5 years ago

Yes, so resample is failing because for numpy >= 1.16 the following happens:

Numpy has detected that you may be viewing or writing to an array returned by selecting multiple fields in a structured array. 

This code may break in numpy 1.16 because this will return a view instead of a copy -- see release notes for details.
  y_in = y_in.view(y_type).reshape(data_in.shape + y_shape)

I'm working on a fix

fjaviersanchez commented 5 years ago

Okay, I think the tests will pass once we merge #49 and I rebase

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.2%) to 99.067% when pulling 83ad65342133274d97bda49b0dc329d42be35b44 on euclid into 2347646eeadf7ffad58101c484c9ea5cec877257 on master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.5%) to 99.793% when pulling a9c0f420f78efd9b56d93b5f8d0e2237c286660e on euclid into 2347646eeadf7ffad58101c484c9ea5cec877257 on master.

fjaviersanchez commented 5 years ago

@dkirkby, I added coverage tests in python2.7 and 3.x but it says that the overall coverage decreased because it takes the average of both runs (py27 and py3x) and, since in py3x it doesn't run the line from __future__ import print_function, division it shows a smaller coverage... I think that the current criterion to approve the coverage is too restrictive but, do you have any suggestions to make one of the tests run the line that I mention above in py3x?

fjaviersanchez commented 5 years ago

I just made the coverage module ignore the from __future__ import line