search

desihub / speclite

Lightweight utilities for working with spectroscopic data
14 stars 19 forks source link

Migrate to Github Actions and Convert Python 2 to Python 3 #65

Closed andyyPark closed 3 years ago

andyyPark commented 3 years ago

This PR moves unit tests from Travis to Github actions and converts Python 2 code to Python 3.

sbailey commented 3 years ago

Thanks. I see the .github/workflows/python-package.yml file, but the workflow itself doesn't appear to be triggered (and the travis tests are still running). Do we need to do something else to actually turn the GitHub Actions on? Or is this an artifact of it being a PR from a fork instead of a branch?

weaverba137 commented 3 years ago

Another question: how exactly does speclite deploy its documentation to ReadTheDocs? I don't see the necessary webhook for that.

weaverba137 commented 3 years ago

@sbailey: GitHub Actions are not being triggered because this is a PR off of a fork, not a branch.

dkirkby commented 3 years ago

@weaverba137 Do you have a suggestion for what we should do differently for the ReadTheDocs integration? The docs already exist at https://speclite.readthedocs.io/en/latest/ but I have been triggering new builds manually.

dkirkby commented 3 years ago

@sbailey @weaverba137 Do you know if there is a way to trigger the GitHub actions on this PR, or should we just merge and see what happens?

weaverba137 commented 3 years ago

@dkirkby, before I give a lot of advice here, let me ask: what is the long-term roadmap for this package? Are you going to continue to support it as an Astropy-affiliated package? Any answer I would give would depend very strongly on that.

dkirkby commented 3 years ago

@weaverba137 My slight preference is to abandon the astropy affiliated package ecosystem (since we are already quite out of sync) and adopt something simpler and more maintainable. However, if you think getting back in sync with astropy is better for long-term support I am open to that also. Whatever we decide, I would like to handle specsim the same way.

dkirkby commented 3 years ago

Does anyone object if I merge this now so the new GHA unit tests have a chance to run? @sbailey @weaverba137

weaverba137 commented 3 years ago

I have no objections if you merge. If you are abandoning astropy-affiliated status, that's fine, but then the best path forward for long-term maintainability is to adopt the DESI package layout.

As far as ReadTheDocs goes, adopting the DESI package layout will take care of a lot of that, but for the record, who is the person responsible for maintaining the RTD account associated with speclite.readthedocs.io?

dkirkby commented 3 years ago

speclite.readthedocs.io is currently under my RTD account but I am happy to transfer this or add another authorized RTD account (if that's possible). Same for specsim.

weaverba137 commented 3 years ago

@dkirkby as long as we know who to contact if RTD is not updating, or if some other change is required, that's all we need.