Closed tloredo closed 2 years ago
Thanks for reporting this @tloredo. Looking back at my correspondence with Mamoru Doi, I see that I was confused about whether the atmosphere was already included in the Table 4 values (despite the fact that it is obvious from the curves).
At this point, I think the simplest fix is to update the metadata for the existing curves to reflect the fact that there is no atmospheric extinction included.
Would it then be useful to add new curves with the Table 4 reference atmosphere included?
I just updated the SDSS filter curve metadata to clarify that no atmosphere is included in these curves.
Closing this now, but feel free to add a new issue if you need a separate set of curves with the X=1.3 atmosphere included.
Hi David. Just a quick follow-up. speclite
came up today in a Rubin DP0 discussion, where we had a quick look at the docs in a Zoom breakout. I noticed that the docs at ReadTheDocs still indicate that the SDSS curves include atmospheric transmission. So it looks like the docs need a quick update.
Thanks @tloredo. The ECSV metadata is already updated (e.g. here) and I am re-opening this issue to update the sphinx docs as well.
@dkirkby would it be possible to add a new set of SDSS filter curves (and arguably make those the default) which include the atmosphere. I'm doing some comparisons with K-correct and only just realized that the discrepancies I'm seeing with my code are likely due to this issue.
Also note that this ticket is a duplicate of #39.
Could this be related to the discrepancies in data flux vs mock flux that Alma and Hiram are seeing?
On Tue, 12 Jul 2022, 19:43 Moustakas, @.***> wrote:
Also note that this ticket is a duplicate of #39 https://github.com/desihub/speclite/issues/39.
— Reply to this email directly, view it on GitHub https://github.com/desihub/speclite/issues/66#issuecomment-1182099666, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5RYR7ZQ5DHXZBUI7DUBV3VTWVEVANCNFSM433GXSQA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
-- Avís - Aviso - Legal Notice - (LOPD) - http://legal.ifae.es http://legal.ifae.es/
Done in #76.
Hi specliters-
In trying to move to
speclite
from some quick-and-dirty synthetic photometry code of my own, using SDSS filters, I found that I could get my calculations to agree w/speclite
only by dropping the atmospheric transmission factor from the SDSS filter responses in my calculations.The
speclite
documentation indicates that its SDSS filter responses are "calculated as the reference response multiplied by the reference APO atmospheric transmission": https://speclite.readthedocs.io/en/stable/filters.html.The filter data tables have comments indicating the same. E.g., for the u band, a comment reads, "Values are the product of the u and atmospheric transmission columns from Table 4 of Doi...": https://github.com/desihub/speclite/blob/v0.13/speclite/data/filters/sdss2010-u.ecsv
Here are the first few entries in the
speclite
SDSS u band filter data file:Here is the content at the start of the Doi+ Table 4 (ASCII version here: https://iopscience.iop.org/1538-3881/139/4/1628/suppdata/aj330387t4_ascii.txt?doi=10.1088/0004-6256/139/4/1628):
I checked a couple other SDSS data files, with similar findings. It appears the
speclite
SDSS filter responses do not include the atmospheric transmission factor.Have I misunderstood something here?