search

desihub / specsim

Quick simulations of spectrograph response
2 stars 10 forks source link

fiberloss method is updated for dithering simulations #103

Closed tolgayapici closed 4 years ago

tolgayapici commented 5 years ago

the previous branch, dithering, was off sync with master and would be hard to resolve the conflicts. created a new branch out of master and added the features needed for dithering simulations.

sbailey commented 5 years ago

@dkirkby could you take a look at the failing Travis tests? They appear to be related to matplotlib / astropy / numpy version incompatibilities, and not directly to this code update (and not just Travis hiccups either).

In addition to the Travis tests, could you also review this PR for merging? Thanks.

weaverba137 commented 4 years ago

@tolgayapici, @dkirkby, does this PR supersede #73?

dkirkby commented 4 years ago

I suspect this PR is no longer relevant but @tolgayapici should confirm.

sybenzvi commented 4 years ago

@dkirkby and @weaverba137, Tolga left DESI at the end of November 2019 and is not maintaining the branch. Given the progress Eddie made using actual dither data we don't really need to merge this into the master. You can close the PR but I suggest keeping the branch around just in case.

weaverba137 commented 4 years ago

Closing PR based on @sybenzvi's advice.