search

desihub / specsim

Quick simulations of spectrograph response
2 stars 9 forks source link

Add support for dithering #58

Open sybenzvi opened 7 years ago

sybenzvi commented 7 years ago

This is a feature request moved from desimodel. Specsim should allow the user to dither the telescope given an observation spot in the focal plane. Some hooks are needed in the config and simulator modules. In principle I could implement them, but to avoid conflicts I'll wait for comments from @dkirkby.

dkirkby commented 7 years ago

There is already a configuration parameter we can use for dithering called instrument.offset.value but the logic in specsim.instrument.initialize() will need to be updated so that:

I don't think any other changes should be necessary (except for docs and unit tests).

tolgayapici commented 7 years ago

we added a parameter called fiber_placement in the fiberloss module. this change enables the dithering (the scripts are at desidithering) to work. by default, it is set to [0, 0] which makes all the normal operations uninterrupted. the changes are currently on dithering branch. can we merge with master?

dkirkby commented 7 years ago

Please make a pull request so I can review & test your changes.

tolgayapici commented 7 years ago

before I make a pull request, I realized that travis tests are failing for python2.7 I will try to find the problem first.

tolgayapici commented 7 years ago

The travis tests fail for transform.py (a file I have not touched) with astropy=development. The last test for the master was done 2 months ago. Is there any change that the astropy[development] has some issues? I have restarted the build of the master and the problem is there too (with transform.py). Do you want me to take a look at transform.py?

dkirkby commented 7 years ago

Thanks for looking into this. I will investigate eventually (and you are welcome to take a look also!)