Updates for new DESIMODEL

desihub / specsim

Quick simulations of spectrograph response

2 stars 9 forks source link

Updates for new DESIMODEL #91

Closed dkirkby closed 6 years ago

dkirkby commented 6 years ago

This is work in progress to:

Update to desimodel 0.9.6
Fix #83
Update notebooks in doc/nb/ (supercedes #89)
Implement QA code to document and track SNR of the nominal DESI ELG sample.

dkirkby commented 6 years ago

Travis tests are failing against the dev version of astropy with multiple instances of:

Unknown ufunc apio13.  Please raise issue on https://github.com/astropy/astropy

I did as instructed: astropy/astropy#7665

sbailey commented 6 years ago

We've already made our tags and tests for the 18.6 software release using desimodel/0.9.6 and specsim/0.11.1 . The incompatibilities appear minor (sigma1d 5.1 vs. 5.22) but are there other major incompatibilities of which we should be aware to include in the 18.6 release notes? This highlights the problem of specsim having its own different desi.yaml with replicated info instead of using the one in desimodel.

dkirkby commented 6 years ago

I found a workaround for astropy/astropy#7665 (which turned out to be an astropy bug) and all tests are passing now.