search

desihub / specter

A toolkit for simulating multi-object spectrographs
Other
8 stars 7 forks source link

Fix fiberloss #12

Closed sbailey closed 8 years ago

sbailey commented 9 years ago

Govinda found that I wasn't using the per-objtype fiberloss inputs from the desimodel throughput files. This pull request fixes that.

Note that the whole concept of a single fiberloss per object type isn't correct: this should be based upon seeing, object size, object profile, and fiber misalignment (see issue #11). This is an intermediate step which is better than doing nothing.

Tests pass (including new ones), and integration test still works.

gdhungana commented 9 years ago

Looks like the big effect is solved. Fiberloss accounted correctly for all object types.