search

desihub / specter

A toolkit for simulating multi-object spectrographs
Other
8 stars 7 forks source link

astropy.io.fits instead of fitsio #19

Closed sbailey closed 8 years ago

sbailey commented 8 years ago

This PR resolves #14 by replacing fitsio with astropy.io.fits . It also re-enables the binscript tests and changes "import numpy as N" to the more standard "import numpy as np".

There are still uses of fitsio in the dev directory for some per-experiment code. That is not part of the standard scripts, specter library, or installation so I'm not worrying about those for now. They could be updated as well in a future cleanup of the dev directory.

weaverba137 commented 8 years ago

This all looks OK, though the test coverage decreased noticeably.

sbailey commented 8 years ago

I added a few tests to improve the I/O coverage that had gone down. The relevant functions actually were called by the scripts, but that was hidden from the coverage checker because the I/O was only called by the scripts, not by the algorithms or any dedicated test. The scripts have more in them than they should, but that refactoring is for another PR...