desihub / specter

A toolkit for simulating multi-object spectrographs
Other
8 stars 7 forks source link

Spotgrid #21

Closed julienguy closed 8 years ago

julienguy commented 8 years ago

New version of psf.spotgrid._xypix , the routine that resamples the spots onto the CCD pixel grid. It is now much more accurate at the expense of an increase of computation time of 30%.

julienguy commented 8 years ago

fixed a bug if xc or yc < 0

weaverba137 commented 8 years ago

It looks like you added pylab as a dependency. I think it is better to explicitly use matplotlib, since that's really what it is.

julienguy commented 8 years ago

argh ... thanks, I am fixing this

On Thu, Nov 12, 2015 at 11:22 PM, Benjamin Alan Weaver < notifications@github.com> wrote:

It looks like you added pylab as a dependency. I think it is better to explicitly use matplotlib, since that's really what it is.

— Reply to this email directly or view it on GitHub https://github.com/desihub/specter/pull/21#issuecomment-156255615.

weaverba137 commented 8 years ago

In the .travis.yml file, change OPTIONAL_DEPS=false to OPTIONAL_DEPS=true to install matplotlib during Travis tests.