move exspec divide-and-conquer algorithm into function

desihub / specter

A toolkit for simulating multi-object spectrographs

Other

8 stars 7 forks source link

move exspec divide-and-conquer algorithm into function #31

Closed sbailey closed 8 years ago

sbailey commented 8 years ago

The divide-and-conquer algorithm for extractions is contained in bin/exspec rather than a library. Move this into a function to make it easier to re-use, and trim down the script. Several advantages:

The script is already tested via test_binscripts, but the coverage tools are blind to what happens internally to a system call
moving this into a function enables a desi-specific extraction wrapper

Starting branch exspec_refactor to do this.

sbailey commented 8 years ago

Heads up: ex2d API change:

Currently uses specrange=(specmin,specmax) to specify which spectra should be extracted. This can cause confusion about whether specmax is included or not. Changing call signature to use specmin and nspec instead, matching the options to the bin/exspec script.

sbailey commented 8 years ago

Fixed by PR #32