search

desihub / specter

A toolkit for simulating multi-object spectrographs
Other
8 stars 7 forks source link

Move data directory into Python package tree #34

Closed weaverba137 closed 8 years ago

weaverba137 commented 8 years ago

In order to work better with Anaconda environments, the data/ directory needs to be moved inside the Python package tree, i.e. to py/specter/data/.

weaverba137 commented 8 years ago

@sbailey, I have a few questions about the data in the data directory.

  1. data/sky/ZenExtinct-KNPO.fits is only referenced by dev/bigboss/bbthru.py. That is, it is not used by the main specter package at all. Can it be removed?
  2. data/sky/sky-uves.fits is only used as an input in py/specter/test/test_binscripts.py. Since it is only used for testing, can that be moved into the data/test directory (which would be moved somewhere inside py/specter/test)?
sbailey commented 8 years ago

specter/data could use a lot of cleaning up, in particular moving larger example files into a separate specter-example repo and perhaps even using the BFG repo cleaner to get them entirely out of the git history -- they predate me learning the downsides of keeping data-like files in git.

For now could you live with just moving data/ into the python directory structure to get it to work with python setup.py install and deal with cleanup/reorganization as a separate step? i.e. let's fix what is broken first, and then separately cleanup. The review prep is not affording me a lot of mental cycles for thinking about how this should really look post-cleanup...

weaverba137 commented 8 years ago

Yes, I will concentrate on just moving the data, but keep this open as a reminder.