desihub / specter

A toolkit for simulating multi-object spectrographs
Other
8 stars 7 forks source link

fix pixelated Gauss-Hermite integration last bin bug #79

Closed sbailey closed 4 years ago

sbailey commented 4 years ago

This PR fixes a 6-year-old bug in the pixellated Gauss-Hermite integration, where the last bin was only integrated for half a bin instead of a full bin. I'm pretty sure this PR is correct though I would appreciate a cross check, perhaps from @lastephey or @julienguy .

Mea culpa: I was the one who introduced the bug 6 years ago; the original pixellated Gauss-Hermite code from Adam Bolton was correct and I broke it in an "optimization" in how the bin boundaries are calculated.