Added zbest data into desidiff.ipynb

desihub / timedomain

Time-domain code.

MIT License

3 stars 14 forks source link

Added zbest data into desidiff.ipynb #46

Closed davidlmoutard closed 3 years ago

davidlmoutard commented 3 years ago

Pulls zbest data as a list of tuples with relevant info (Z, ZERR,ZWARN, SPECTYPE). Does this prior to subtraction, data should be available to create filters based on redshift.

AlexGKim commented 3 years ago

@davidlmoutard , Staring more I found a bug in your code

tid is an array, so I think this is correct.

        for t in tid:
            tid_ind = list(z['TARGETID']).index(t)
            z_data.append((tid, z[tid_ind]['Z'], z[tid_ind]['ZERR'], z[tid_ind]['ZWARN'], z[tid_ind]['SPECTYPE']))

Did your previous code actually fill z_data with anything?

AlexGKim commented 3 years ago

@davidlmoutard can you run what I just checked into master and confirm that it does what you want it to do?