divijsharma18
commented
3 years ago I see we have changed that in the master recently
On Thu, Sep 23, 2021 at 9:05 AM Divij Sharma @.***> wrote:
I was actually thinking about that too. I don't need to append tid at all actually, but I just wrote it because that is what we have done for z_data. Should the z_data line also say t instead of tid?
On Thu, Sep 23, 2021 at 8:22 AM AlexGKim @.***> wrote:
@AlexGKim commented on this pull request.
I think there is a bug with tid
In desidiff/nb/desidiff.ipynb:
" z_data.append((tid, z[tid_ind]['Z'], z[tid_ind]['ZERR'], z[tid_ind]['ZWARN'], z[tid_ind]['SPECTYPE']))\n",
- " \n",
- " ra_dec_data.append((tid, ra_dec[ra_dec_ind]['TARGET_RA'], ra_dec[ra_dec_ind]['TARGET_DEC']))\n",
Should this be t and not tid?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
I was actually thinking about that too. I don't need to append tid at all actually, but I just wrote it because that is what we have done for z_data. Should the z_data line also say t instead of tid?
On Thu, Sep 23, 2021 at 8:22 AM AlexGKim @.***> wrote: