desihub / tutorials

DESI tutorials
BSD 3-Clause "New" or "Revised" License
43 stars 16 forks source link

update simspec tutorial to use quickspectra #11

Closed sbailey closed 6 years ago

sbailey commented 6 years ago

Updates the simulating-desi-spectra tutorial to use quickspectra, while keeping the original tutorial as quickgen.ipynb. The new tutorial:

External vetting welcome, or otherwise I will self-merge by Monday and we can have fun with lots of external vetting during the tutorial session.

Full disclosure: my git-fu failed me and I ended up re-adding the original tutorial under a new name instead of moving it in a way that would preserve history. For jupyter notebooks I don't think that is a big deal, but if someone feels strongly we could fix this properly in a different branch.

moustakas commented 6 years ago

This is very nice, @sbailey.

dkirkby commented 6 years ago

I agree this looks great! Some nitpicking suggestions in case you have time:

sbailey commented 6 years ago

Thanks for the suggestions; I implemented those in the notebook.

The srun command does propagate the notebook environment into the batch job, but it is possible that the user has commands in their .bashrc.ext, .bash_profile.ext, or .tcshrc.ext that could override that. I haven't mapped out the full phase space of what works and what doesn't, so for now I just added a note about what to look for if that command fails. I have tested this notebook with "clean" .bash*.ext files that do not configure any DESI code or environment variables by default (@tskisner finally convinced me that that really was the best thing...)