search

desihub / tutorials

DESI tutorials
BSD 3-Clause "New" or "Revised" License
43 stars 16 forks source link

Update notebooks to 19.12, CFS filesystem #39

Closed weaverba137 closed 4 years ago

weaverba137 commented 4 years ago

This PR:

Still need to work on these notebooks:

Other active notebooks have already been tested on 19.12, or on master, for the fiberassign notebooks. Do we want to move to running the fiberassign notebooks on an explicit release?

weaverba137 commented 4 years ago

To save time, I'm declaring the redshift database tutorial done, since it works fine when only program='dark' is loaded. Loading both bright and dark will be moved to a separate issue on desispec.

weaverba137 commented 4 years ago

@sbailey, please take a look at this block of text from dc17a-truth. What would be the equivalent file(s) and text for reference run 19.12?

The actual true input spectra were not included with dc17a, but they are available at NERSC in:

/project/projectdirs/desi/datachallenge/dc17a-twopct/targets/{group}/truth-{brickname}.fits

where group = brickname[0:3], i.e. the first 3 characters of the brickname.

NOTE: future data challenges will group the input truth files by healpix like the output spectra, but dc17a did not.

The above target came from brickname 0084m085. If you are running locally (not at NERSC), go get that file now, e.g.

mkdir -p targets/008/
scp edison.nersc.gov:/scratch2/scratchdirs/sjbailey/desi/dc17a/targets/008/truth-0084m085.fits targets/008/

Let's see what is in that file:

weaverba137 commented 4 years ago

@sbailey , can you take a look at this please?

sbailey commented 4 years ago

Thanks. Let's merge this as-is, and I'll spin the dc17a-truth question into a new ticket to solve independently of the other progress in this PR.

weaverba137 commented 4 years ago

@sbailey, please do not create a tag! I want to put a warning into two notebooks that they are still broken. I was hoping you would address the question but not close the PR. Note that the WIP tag was still in effect!

In addition to dc17a-truth being broken, #32 is still broken.

sbailey commented 4 years ago

For the remaining problems with tutorials on 19.12, please open one ticket per problem to avoid the omnibus ticket effect of some things being solve but not others.

I moved the dc17a-truth question into ticket #40 .

Ideally the fiberassign notebooks would refer to 19.12, but ok to leave them on master for this iteration too if that is needed.

I won't make a tag. Thanks.