Closed Ragadeepika-Pucha closed 2 years ago
Hi @Ragadeepika-Pucha . Thanks for this PR!
I have some suggestions prompted by thinking about this notebook as an on-boarding tool for students and postdocs that are new to DESI. The side effect is that those suggestions could be annoying to more experienced DESI users, so feel free to ignore them!
sv1_targetmask.desi_mask
it would be nice to have some short narrative around it, i.e. "Although this looks like a very long list of targets, there are only four main target types that we use in DESI: [some link explaning the generalities about BGS, ELG, LRG and QSO]. The long list simply reflects the complexity in the target selection process."is_bgs = (sv1_desi_tgt & sv1_desi_mask['BGS_ANY'] != 0)|(sv2_desi_tgt & sv2_desi_mask['BGS_ANY'] != 0)|(sv3_desi_tgt & sv3_desi_mask['BGS_ANY'] != 0)
, it would be useful to have some short narrative around it, i.e. "For instance, the following line selects all the BGS targets observed in the SV1, SV2 and SV3 campaigns.". Finally, I replaced your matplotlib style lines with a single line plt.style.use('../mpl/desi.mplstyle')
Thanks!
Hi @forero, Thank you very much for the comments! They have been very useful in improving the tutorial notebook. A few points to note:
FAFLAVOR
parts in the notebook, since this is mostly internal to the collaboration and the target selection.Thank you! Raga
Thanks @Ragadeepika-Pucha! Thanks for including some of the additional links. Unfortunately, I don't know what would be the best reference regarding EFFTIME_SPEC, perhaps @julienguy knows? Apart from that, I think this is ready to merge.
Thank you @forero. I can create another PR when the public links are available and update the tutorial before the EDR release. Can you please merge this PR or should we ask Stephen Bailey for the same?
Merged! Thanks @Ragadeepika-Pucha
This notebook is a modification from the everest tutorial notebook, and also showcases the summary redshift catalogs.