search

desihub / tutorials

DESI tutorials
BSD 3-Clause "New" or "Revised" License
43 stars 17 forks source link

Readme no nersc account #91

Closed stephjuneau closed 1 year ago

stephjuneau commented 1 year ago

I only modified the top-level README file. I added a Table of content, a section on external database access including what Stephen asked about TOPCAT access to the TAP handle. I also added a one-line section on DESI Data Acknowledgments pointing to the Data Doc website.

forero commented 1 year ago

@stephjuneau Please go ahead and merge this branch whenever you are ready. I will proceed merging the database branch afterwards.

stephjuneau commented 1 year ago

OK so I made the two small changes requested by Ben (removed the extra "e" in acknowledgments URL). I have also just added a new README to the getting_started/ folder. This links to the other two previous .md files but we could incorporate them directly if preferred? @akremin will need to update the link to the EDR paper repo. (@forero what do you think of the new README file? do the links to the other md files work for you?)

stephjuneau commented 1 year ago

I was trying to let Ben know that I made his two requested changes but I accidentally re-requested a review. Not sure that was needed but I'll wait to hear a minimum of one approval before merging (whoever sees this first :-) )

stephjuneau commented 1 year ago

Hi @weaverba137 are you OK with me merging this PR? I've made both fixes (and added a README in case you want to see it: https://github.com/desihub/tutorials/blob/readme-no-nersc-account/getting_started/README.md) Edit: Jaime requested to merge this one first before he merges the database notebook branch)

weaverba137 commented 1 year ago

I found some additional problems, but they can be fixed quickly.

stephjuneau commented 1 year ago

OK, I made both new fixes and will merge. Thanks for the reviews!