Closed 3j14 closed 1 year ago
I really like the new design of the tabs. Some minor things:
@nlwach Thank you for your feedback!
Regarding the color of the disabled
tab: Yes, I will change this and make the difference more noticeable.
As for discarding the measurement: Hm, good point. Obviously the button should do something. Making it delete the measurement is difficult because the same form is also displayed when editing the form. In that context, discard would not mean to delete the measurement but discard changes.
@jnsdrtlf good point. I will implement this. How do you feel about having a modal to confirm to discard the changes?
The discard button behaves now the following way: In the first tab the discard button redirects to the map view. In the other tabs the button redirects to the measurement detail page
@nlwach thanks for your changes and review! Merged now :)
This pull requests introduces a new layout that uses tabs to navigate the different steps of the measurement form or the two pages of the course administration.
To make the tabs work on mobile devices, they are not places within the title bar but instead below in the content:
For easier configuration, two classes
TabNavigation
andTab
have been introduced. These classes are subclasses ofRenderable
and their__str__
method returns renderable HTML.Additionally, the package structure of
gcampus/core/views
has been changed and may require thorough review.Note: There is now only one
add-measurement
endpoint. After adding the measurement, the title changes to "Edit Measurement #…".Other fixes:
StructureIndexEditView
to retrieve the correct instance from the current measurement.StructureIndexEditView
orBiologicalParameterFormSetView
for a measurement that is not of typeFlowType.RUNNING
To-do: