search

desko27 / react-call

⚛️ 📡 Call your React components
https://react-call.desko.dev
MIT License
453 stars 7 forks source link

Publish commonJS modules #6

Closed mariusGundersen closed 2 months ago

mariusGundersen commented 2 months ago

I prefer ES modules, but unfortunately I can't use them in my current project, because react only has commonJS exports. Can you publish the package containing both ESM and CJS modules? That way I can use it in my project.

desko27 commented 2 months ago

Hi @mariusGundersen, thanks for you request.

It has been a long time since I had to deal with CJS so I wasn't actually planning on adding support for it. Although I can understand some of you can't choose.

I think #8 should do but I'm not sure how to test it, especially TypeScript types. Are you using some sort of webpack/babel setup? I've published react-call@next as a pre-release for testing purposes. Could you please give it a try and let me know?

mariusGundersen commented 2 months ago

For my scenario I'm doing no bundling or transpilation, that is part of the problem. If I did transpile then maybe it would work. I will give it a try on Monday, when I'm back to work