search

desktop-app / cmake_helpers

CMake helper scripts.
93 stars 73 forks source link

Revert "Force usage of GSL fork because of a libstdc++ bug." #320

Closed mochaaP closed 12 hours ago

mochaaP commented 1 year ago

This reverts commit 982546b169df3d479e6511425870327559b38a89. https://github.com/microsoft/GSL/commit/e64c97fc2cfc11992098bb38eda932de275e3f4d

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ilya-fedin commented 12 months ago

Perhaps we should wait for a release first?

mochaaP commented 12 months ago

Usually yes, but upstream haven't released a version for a year and round 😕

ilya-fedin commented 12 months ago

Then there's no reason to revert this. Using the bundled one is better than having reports about crashes.

Cbnbrain commented 8 months ago

bulk-sponsorships-template.csv .patch

ilya-fedin commented 19 hours ago

@mochaaP please update minimal required version to 4.1.0

mochaaP commented 18 hours ago

ack