desktop-app / lib_webrtc

WebRTC helper library.
18 stars 4 forks source link

Reopen default device if default is changed #13

Open Predelnik opened 1 year ago

Predelnik commented 1 year ago

After default device is changed in the system, the app will use new default.

Not sure which openal-soft version is good enough for this to work, seems to work well with current master. Hopefully next release of openal will be sufficient.

ilya-fedin commented 1 year ago

Isn't the version with support for this API supposed to do this transparently?

Predelnik commented 10 months ago

You mean it would work automatically after updating the library? I'm not sure but feel free to check

ilya-fedin commented 10 months ago

Yeah. If you want the fix to land sooner, you can do an implementation without using unreleased openal APIs, e.g. look how it's implemented in tdesktop since long time ago: https://github.com/telegramdesktop/tdesktop/blob/dev/Telegram/SourceFiles/platform/win/audio_win.cpp

Predelnik commented 10 months ago

Ok, unfortunately, for me, the issue is not high priority for now. Bit I might look into it.

john-preston commented 9 months ago

This will work differently soon, with native implementations for Windows / macOS. A fallback implementation on Linux using OpenAL APIs would be nice, I guess. I'll share some details soon.