desktop / desktop

Focus on what matters instead of fighting with Git.
https://desktop.github.com
MIT License
19.71k stars 9.4k forks source link

Transparency in PNG files shown white #18111

Open jtsage opened 8 months ago

jtsage commented 8 months ago

The problem

It's really a nit-pick issue, but when viewing a 2-up of (admittedly very small) transparent background images, the background is show as solid white. This isn't so bad when the image content isn't white :

2024-01-31 13_15_30-GitHub Desktop

However, it can be a problem when the image content is in fact white:

2024-01-31 13_17_29-GitHub Desktop

It's not a huge deal, but it has caused me to backtrack a few times and make sure my image process wasn't accidentally exporting with a non-intended background.

Release version

Version 3.3.8 (x64)

Operating system

Windows 11

Steps to reproduce the behavior

  1. Commit a white on transparent small PNG to a repository
  2. Change the contents of the PNG
  3. The diff supplied is somewhat useless.

Possibly easier -

Clone https://github.com/FSGModding/FSG_Mod_Assistant Most recent commit with issue is Better quality export of black context menu icons

Log files

No response

Screenshots

Actual files in question:

ui-icon-open-explorer@2x blk-ui-icon-file-delete@2x

Additional context

No response

steveward commented 8 months ago

Thanks for the detailed issue @jtsage! I'll mark this as an enhancement for future improvement.

kitt159 commented 3 months ago

Interesting is that when the desktop window is itself transparent (i have set transparent window in KDE plasma when window is moving) the transparent background of png is shown as classical white-grey squares. So it looks like the transparency in png is rendered correctly but "under" the image is white background?