search

desktop / desktop

Focus on what matters instead of fighting with Git.
https://desktop.github.com
MIT License
19.73k stars 9.42k forks source link

AppData folder has large cache which affects "roaming profile" users #6523

Open LipkeGu opened 5 years ago

LipkeGu commented 5 years ago

It would be nice when Github Desktop doesnt store its temp files in the roaming part of of a user profile C:\Users\LipkeGu\AppData\Roaming\GitHub Desktop\Cache

Also in Windows the location is limit to a specified size (30MB) in enterprises, This folder "Roaming" gets uploaded to the server when logging of and downloaded when logging on. On slow lines its can take up to hours.

It would be nice when this Bug could be fixed and the path is used in further versions: C:\Users\LipkeGu\AppData**local**\GitHub Desktop\Cache

shiftkey commented 5 years ago

@LipkeGu thanks for the report.

It would be nice when Github Desktop doesnt store its temp files in the roaming part of of a user profile C:\Users\LipkeGu\AppData\Roaming\GitHub Desktop\Cache

This is a folder that the Electron runtime uses, and isn't managed by GitHub Desktop. On my Windows dev machine it is currently 17.9 MB in size.

Also in Windows the location is limit to a specified size (30MB) in enterprises, This folder "Roaming" gets uploaded to the server when logging of and downloaded when logging on. On slow lines its can take up to hours.

This is a great point, and not something I'd thought about before.

It would be nice when this Bug could be fixed and the path is used in further versions: C:\Users\LipkeGu\AppData*local*\GitHub Desktop\Cache

Sadly this folder isn't one that GitHub Desktop controls, and we'd need to chat with the Electron team about how they're using this to see if it can be optimized or removed. This also might have been improved in a later version of Electron (we're on v2, and evaluating v3, and they just released v4 before the Christmas break).

I'm going to tweak the title to reflect that it's not about "awareness" of the roaming profile, but how it's being used.

shiftkey commented 5 years ago

An upstream discussion about customizing this location has been opened https://github.com/electron/electron/issues/18309

ThomasMoutel commented 3 years ago

Hi @shiftkey, a pull request #19693 https://github.com/electron/electron/pull/19693 has been opened more than one year ago to have this fixed, but no-one seems to care about it. Do you know how we can get it reviewed and integrated?

shiftkey commented 3 years ago

@ThomasMoutel I'm no longer working on GitHub Desktop

steveward commented 2 years ago

Requested in #13308:

GitHub Desktop under Windows create and save lot of data under %APPDATA%\GitHub Desktop. This is part of server sync profiles in enterprise environment. Often this folder is size limited. In often situation a user has a expensive small SSD for OS and APPs and e cheap big HDD for data. So please save caches and temp data under %LOCALAPPDATA% or let the user select an folder for caches.