search

desktop / dugite-native

A toolchain for building a portable, cross-platform Git for applications
GNU General Public License v2.0
198 stars 108 forks source link

Can't commit with git-secrets #178

Open zarsky-broad opened 5 years ago

zarsky-broad commented 5 years ago

Description

Git-secrets fails to run (I think because it can't find git-sh-setup). Specifically, the error raised points to line 46, and the built-in git has a weird exec-path:

$ /Applications/GitHub\ Desktop.app/Contents/Resources/app/git/bin/git --exec-path
//libexec/git-core

Version

Steps to Reproduce

Set up git-secrets in a repo, then try to commit any file.

Expected Behavior

Commit succeeds.

Actual Behavior

Commit fails with error No such file or directory.

Additional Information

Logs

2019-01-18T22:18:28.902Z - error: [ui] `git commit -F -` exited with an unexpected code: 1.
/usr/local/bin/git-secrets
/usr/local/bin/git-secrets: line 46: /Applications/GitHub: No such file or directory
shiftkey commented 5 years ago

@zarsky-broad thanks for the report!

This is the same root cause as https://github.com/desktop/dugite-native/issues/164 and needs to be addressed in the embedded Git. I'm going to move this over the related project so we can track it there.

hackbom commented 3 years ago

aim su sorry