search

desktop / dugite-native

A toolchain for building a portable, cross-platform Git for applications
GNU General Public License v2.0
193 stars 108 forks source link

add 386, arm, and arm64 to ubuntu buildscripts #368

Closed theofficialgman closed 1 year ago

theofficialgman commented 2 years ago

current use of 64 and 32 in github actions is unaffected and will function as before

added arm, and arm64 as acceptable TARGET_ARCH options

this allows for making local builds of dugite-native on arm/arm64 hardware using the same buildscripts used in the github actions. future changes may allow for building through github actions as well using cross compilation (or self hosted runner, see below)

theofficialgman commented 2 years ago

@shiftkey LGTM

you can see I also have a separate branch on my fork where I am personally using the always free tier of the Oracle Cloud services with Ampere ARM A1 processors to build with a github self hosted runner on a bionic arm64 image https://www.oracle.com/cloud/free/ https://github.com/theofficialgman/dugite-native/commit/96d5e078330eee56f54b48dd7d52dcb3b3689005 https://github.com/theofficialgman/dugite-native/actions/runs/2779374451

I don't see why the desktop team can not do the same.

theofficialgman commented 1 year ago

@tidy-dev @shiftkey @sergiou87 @niik I am once again requesting that this be merged

it is a non-breaking change to your CI and makes building on x86, arm, and arm64 linux work out of the box without having to constantly rebase this patch on master

theofficialgman commented 1 year ago

closing in favor of a new cross compiling PR that you WILL merge