Bump to 2.39.3 - Githubissues

desktop / dugite-native

A toolchain for building a portable, cross-platform Git for applications

GNU General Public License v2.0

193 stars 108 forks source link

Bump to 2.39.3 #445

Closed tidy-dev closed 1 year ago

tidy-dev commented 1 year ago

Bumps Git to 2.39.3 and Git for Windows to v2.39.3.windows.1

EDIT:

Linux builds were not being picked up by action.
Found that on April 3rd, actions no longer supports ubuntu-18.04
Tried ubuntu-latest which should be ubuntu-22.04 and ubuntu-20.04 and they both failed.
Reverted #414 - Add ARM64, ARM32, and x86 Linux Builds and updated to ubuntu-22.04 and build succeeds. We will have to revisit Arm64 builds for linux.

theofficialgman commented 1 year ago

@tidy-dev I'll look into why it broke I actually tested on focal before merging the PR and it went fine

tidy-dev commented 1 year ago

@theofficialgman Yeah. It looks like it was merged March 15th and the support for ubuntu-18.04 dropped on April 3rd. Thus, it probably did work then.

theofficialgman commented 1 year ago

Please do not merge this PR. It has been superseded by https://github.com/desktop/dugite-native/pull/446

niik commented 1 year ago

Please do not merge this PR. It has been superseded by https://github.com/desktop/dugite-native/pull/446

The release has already been made and it had to get done yesterday in order for GitHub Desktop to be able to ship today. This release contains fixes for several Git security vulnerabilities and is high priority. Please update your PR once this is merged and we'll take a look at it separately.

theofficialgman commented 1 year ago

I would have prefered that the PR was not merged since commit history is now worse for now reason (there is no issue with a tag existing outside of the master branch which was the case)

Regardless, I have updated the PR to revert these changes