search

desktop / dugite-native

A toolchain for building a portable, cross-platform Git for applications
GNU General Public License v2.0
198 stars 108 forks source link

CI: rework patches to lower GLIBC requirements #501

Closed theofficialgman closed 1 year ago

theofficialgman commented 1 year ago

This patch is based on my changes I have made in various other github projects to produce a more stable and inclusive GLIBC lowering method that better matches what chromium developers are doing.

This now includes 32bit architectures (armhf and x86) lowering as well.

https://github.com/theofficialgman/dugite-native/actions/runs/5448912175

sergiou87 commented 1 year ago

Thank you @theofficialgman

Instead of having all these patches, have you considered using a Docker image that already has the glibc version we want to support? That'd be probably more reliable in case GitHub Actions runners upgrade to something that breaks this 🤔

theofficialgman commented 1 year ago

Thank you @theofficialgman

Instead of having all these patches, have you considered using a Docker image that already has the glibc version we want to support? That'd be probably more reliable in case GitHub Actions runners upgrade to something that breaks this 🤔

An upgrade cannot break this. It is stable with the distro version and should work even on 22.04. please merge.

I am not interested in docker since it requires reworking a significant portion of the yml. Meanwhile this is a self contained single step that is used by one of the biggest software companies in the world.

If we wanted to support GLIBC 2.17 (what this PR supports) that means using a Ubuntu 13.04 container. Using such an old distro is liable to be ripe with security issues and other bugs that a supported distro like 20.04 is not. The very outdated compiler can even introduce bugs into the compiled code.

sergiou87 commented 1 year ago

Closing it in favor of https://github.com/desktop/dugite-native/pull/502