Bump artifact-related actions to v4

desktop / dugite-native

A toolchain for building a portable, cross-platform Git for applications

GNU General Public License v2.0

198 stars 108 forks source link

Bump artifact-related actions to v4 #513

Closed sergiou87 closed 2 months ago

sergiou87 commented 3 months ago

Upgrade upload-artifacts and download-artifacts to v4
In order to do that, bump the GLIBC requirements by using Ubuntu 20.04 to build Dugite
I noticed macos-11 runners are not available anymore, so I bumped those to macos-12 and we will use Xcode 13.1 from now on (it's the oldest one available, for maximum compatibility).

sergiou87 commented 3 months ago

Hey @theofficialgman 👋

Version 3 of the actions upload-artifacts and download-artifacts is gonna be deprecated soon, so we want to move to v4. However, v4 requires Node 20 which in turn requires GLIBC 2.28.

Do you still need GLIBC 2.17 for the Linux builds or is it now a good time to bump them to 2.28? If 2.17 is still required, could you try to fix this issue? Otherwise, we lack the time and expertise to make it happen… 😕

Thanks in advance 🙏

theofficialgman commented 3 months ago

Do you still need GLIBC 2.17 for the Linux builds or is it now a good time to bump them to 2.28?

That's a question up to @shiftkey

shiftkey commented 3 months ago

I think I'm good to do this upgrade, and handle the comms when we publish the first version of the Linux builds that need a later glibc...

theofficialgman commented 3 months ago

Ok. @sergiou87 then just bump ubuntu:18.04 to ubuntu:20.04 in the ci.yml in all 3 places