search

desktop / dugite

Elegant bindings for working with Git in your Node applications
MIT License
462 stars 149 forks source link

add ARM64, ARM32, and x86 Linux to update-embedded-git #522

Closed theofficialgman closed 1 year ago

theofficialgman commented 1 year ago

Spiritual successor to https://github.com/desktop/dugite-native/pull/330 Fixes https://github.com/desktop/dugite-native/pull/315 Replacement for https://github.com/desktop/dugite-native/pull/368 Closes https://github.com/desktop/dugite-native/issues/158 Closes https://github.com/desktop/dugite/issues/521 progress for https://github.com/shiftkey/desktop/issues/251

in tandum with https://github.com/desktop/dugite-native/pull/414

@desktop I have done your job for you, now LGTM!

theofficialgman commented 1 year ago

sorry I don't want to have to do this but I am going to have to start doing weekly pings to the relavent devs so that this can be merged. as seen in the above comment this is a highely requested feature, closes many issues, and is a blocker for other projects

LGTM! @shiftkey @sergiou87 @niik

sergiou87 commented 1 year ago

Hey @theofficialgman! I will try to find some time for this. Sorry we haven't been very responsive, we're a very small team 😓

First we need to get https://github.com/desktop/dugite-native/pull/414 merged, then continue with this one.

theofficialgman commented 1 year ago

@sergiou87 no worries. I appreciate the response. I know that some of you probably work on multiple projects so I wouldn't want this to get lost.

sergiou87 commented 1 year ago

@theofficialgman would you mind adding actions to the remaining OS + arch combinations (Linux x86/arm/arm64 and macOS arm64)? Other than that I think everything in this PR looks great 😄

theofficialgman commented 1 year ago

@theofficialgman would you mind adding actions to the remaining OS + arch combinations (Linux x86/arm/arm64 and macOS arm64)? Other than that I think everything in this PR looks great 😄

@sergiou87 the other combinations are already added/present. so I am not sure what you are talking about.

theofficialgman commented 1 year ago

oh nevermind I see what you requested.

I don't think I can do that because arm64 is not the native architecture of the github runner. so the yarn test will fail due to not being able to run any native binaries https://github.com/desktop/dugite/blob/main/.github/workflows/ci.yml#L56

sergiou87 commented 1 year ago

Sigh… you're right, I always forget about that detail 🤦‍♂️

theofficialgman commented 1 year ago

I hope a new release comes soon with these changes. git 2.40.0 came out a few days ago so now seems like a reasonable time.