search

desktop / dugite

Elegant bindings for working with Git in your Node applications
MIT License
462 stars 149 forks source link

fix: missing require to `fs.rmSync`. #538

Closed richardo2016 closed 1 year ago

richardo2016 commented 1 year ago

Hello, this PR aims to solve this issue:

https://github.com/desktop/dugite/issues/523

I was actually surprised by this issue. It is a very obvious and easily fixable error. Why didn't any official member handle it before? Was it simply because the path that used rmSync was hardly triggered? But due to another issue with https_proxy, this path can be easily triggered on Windows.

richardo2016 commented 1 year ago

@shiftkey @niik Hi! Could you please do a review for this PR?

tidy-dev commented 1 year ago

Hmm.. I see the checks are not running. @richardo2016 would you mind merging the main branch in to get a fresh commit to trigger the ci (and just update since this pr got a little stale, sorry about that) 🙏 ?

richardo2016 commented 1 year ago

Hmm.. I see the checks are not running. @richardo2016 would you mind merging the main branch in to get a fresh commit to trigger the ci (and just update since this pr got a little stale, sorry about that) 🙏 ?

No problem, I'll try merge main branch to see if the checks running.