desmondmorris / node-twitter

Client library for the Twitter REST and Streaming API's.
https://www.npmjs.com/package/twitter
MIT License
1.27k stars 237 forks source link

Fix issue where promise-style requests throw an error if no params are passed #270

Open ryangiglio opened 6 years ago

ryangiglio commented 6 years ago

With callback-style requests, the params argument is always present whether it's actually a params object or a function. But with promise-style requests, it's possible to make a call without the params argument at all, so we need to check that it's defined before trying to use it.

markadrake commented 6 years ago

The only checks here that are failing are based on another dependency using const in strict mode.

Will someone please consider merging this sooner than later?

Also are the failing versions of NPM in the CI Build actually supported? Can they be removed?

peterpme commented 6 years ago

Hey @ryangiglio if you're still interested in a promise implementation, we rewrote node-twitter from the ground up here:

https://github.com/preposterous/twitter-lite