desmos-labs / desmos

Improving the well-being of users on social networks through the blockchain technology.
https://desmos.network
Apache License 2.0
104 stars 46 forks source link

refactor: use `RegisterAminoMsg` to register Amino encodings #1187

Closed dadamu closed 1 year ago

dadamu commented 1 year ago

Description

This PR replaces legacy amino registration of msgs into RegisterAminoMsg in order to avoid the bug that a registered Msg name that is too long when signing on ledger Nano device. See: https://github.com/cosmos/cosmos-sdk/issues/10870


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c368dc1) 80.80% compared to head (03ff088) 80.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1187 +/- ## ======================================= Coverage 80.80% 80.80% ======================================= Files 194 194 Lines 17310 17310 ======================================= Hits 13987 13987 Misses 2727 2727 Partials 596 596 ``` | [Impacted Files](https://app.codecov.io/gh/desmos-labs/desmos/pull/1187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs) | Coverage Δ | | |---|---|---| | [x/profiles/types/codec.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9wcm9maWxlcy90eXBlcy9jb2RlYy5nbw==) | `100.00% <100.00%> (ø)` | | | [x/reactions/types/codec.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9yZWFjdGlvbnMvdHlwZXMvY29kZWMuZ28=) | `51.35% <100.00%> (ø)` | | | [x/relationships/types/codec.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9yZWxhdGlvbnNoaXBzL3R5cGVzL2NvZGVjLmdv) | `100.00% <100.00%> (ø)` | | | [x/reports/types/codec.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9yZXBvcnRzL3R5cGVzL2NvZGVjLmdv) | `58.13% <100.00%> (ø)` | | | [x/subspaces/types/codec.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9zdWJzcGFjZXMvdHlwZXMvY29kZWMuZ28=) | `58.66% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.