Closed dadamu closed 1 year ago
Patch coverage: 70.58
% and project coverage change: -0.02
:warning:
Comparison is base (
ae245f3
) 80.92% compared to head (19ea490
) 80.90%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@RiccardoM I tested it by the ci process inside desmos-bindings: https://github.com/desmos-labs/desmos-bindings/blob/main/.github/workflows/chain-interaction.yml
Do you think we should have a similar ci test inside Desmos as well?
@dadamu Yes I think it would be better. Since it's something we are going to implement inside the Desmos Core, it would be better to have a test here. Can you add it to this PR please? It would just need to create a contract and perform some operations and queries to make sure the Any
type is serialized as we expect
Description
After discussing with wasmd team, the best way to have custom wasm any for desmos-bindings is injecting a custom any resolver to the codec. https://github.com/CosmWasm/wasmd/issues/1454#issuecomment-1614355169
This PR creates a custom
InterfaceRegistry
with a custom any resolver functionResolve
in order to have a custom any JSON encoding in base64 for our contract SDK. As a result, we can usewasmd
directly without forking it.In the other word, it moves the logic of this commit into Desmos.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change