desmos-labs / desmos

Improving the well-being of users on social networks through the blockchain technology.
https://desmos.network
Apache License 2.0
104 stars 46 forks source link

feat!: implement expired subspace fee grant deletion #1198

Closed dadamu closed 1 year ago

dadamu commented 1 year ago

Description

This PR implements expired subspace fee grant deletion mentioned in ADR-017.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.46 :warning:

Comparison is base (275eee9) 80.95% compared to head (ce8ef22) 80.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1198 +/- ## ========================================== - Coverage 80.95% 80.49% -0.46% ========================================== Files 215 218 +3 Lines 18062 18289 +227 ========================================== + Hits 14622 14722 +100 - Misses 2829 2955 +126 - Partials 611 612 +1 ``` | [Impacted Files](https://app.codecov.io/gh/desmos-labs/desmos/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs) | Coverage Δ | | |---|---|---| | [x/subspaces/module.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9zdWJzcGFjZXMvbW9kdWxlLmdv) | `12.58% <0.00%> (ø)` | | | [x/subspaces/types/models\_feegrant.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9zdWJzcGFjZXMvdHlwZXMvbW9kZWxzX2ZlZWdyYW50Lmdv) | `78.57% <61.53%> (-0.38%)` | :arrow_down: | | [x/subspaces/abci.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9zdWJzcGFjZXMvYWJjaS5nbw==) | `100.00% <100.00%> (ø)` | | | [x/subspaces/keeper/feegrant.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9zdWJzcGFjZXMva2VlcGVyL2ZlZWdyYW50Lmdv) | `94.32% <100.00%> (+2.92%)` | :arrow_up: | | [x/subspaces/legacy/v7/store.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9zdWJzcGFjZXMvbGVnYWN5L3Y3L3N0b3JlLmdv) | `100.00% <100.00%> (ø)` | | | [x/subspaces/simulation/decoder.go](https://app.codecov.io/gh/desmos-labs/desmos/pull/1198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=desmos-labs#diff-eC9zdWJzcGFjZXMvc2ltdWxhdGlvbi9kZWNvZGVyLmdv) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.