Closed dadamu closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
cfefad2
) 81.46% compared to head (22ed971
) 81.04%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Currently, the
sdk.MessageEventType
is emitted twice in Desmos, it is because that cosmos-sdk already handles the default message type event. As we can see, the example transaction has two message type event:To fix it, we can safely remove the
sdk.MessageEventType
event inside Desmos modules. References: https://docs.cosmos.network/v0.47/learn/advanced/events#default-events https://github.com/cosmos/cosmos-sdk/blob/v0.47.5/baseapp/baseapp.go#L848Author Checklist
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change