feat!: improve events emissions

RiccardoM commented 5 months ago

Description

This PR improves the overall event emissions by standardizing the event names. It also adds missing attributes and events emissions where useful.

Closes: DCD-441, DCD-442, DCD-443, DCD-444, DCD-445

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

[x] included the correct type prefix in the PR title
[x] added ! to the type prefix if API or client breaking change
[x] targeted the correct branch (see PR Targeting)
[x] provided a link to the relevant issue or specification
[x] followed the guidelines for building modules
[x] included the necessary unit and integration tests
[ ] added a changelog entry to CHANGELOG.md
[x] included comments for documenting Go code
[x] updated the relevant documentation or specification
[x] reviewed "Files changed" and left comments if necessary
[x] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Summary by CodeRabbit

New Features
- Enhanced event naming and attributes across various modules for clarity and consistency.
Refactor
- Updated event types and attributes in profiles, reports, and subspaces modules to reflect semantic changes.
- Standardized event naming convention across the application.
Documentation
- Updated documentation to reflect the new event naming and attribute changes.

coderabbitai[bot] commented 5 months ago

Walkthrough

The changes involve a systematic renaming of event types and attributes across multiple files to enhance consistency and readability. This effort aims to standardize event naming conventions and improve the overall clarity of event-related code within the system.

Changes

Files	Change Summary
`x/profiles/keeper/..._dtag_transfers.go`, `x/profiles/keeper/..._test.go`, `x/profiles/spec/05-events.md`, `x/profiles/types/events.go`	Renamed and adjusted event types and attributes in the profiles module for clarity and semantic accuracy.
`x/reports/types/events.go`, `x/subspaces/keeper/..._server.go`, `x/subspaces/keeper/..._test.go`, `x/subspaces/types/events.go`	Updated event types and attributes in reporting and subspace modules for consistency and clarity.
`.changeset/entries/22c2a6c7f91416899301d06b3b3a7a6bb3a324e0d8575cd332a3558e4eb7e8f0.yaml`	Refactored event and attribute names in the `other` module for better naming consistency.

"In the realm of code, where logic intertwines,
A rabbit hopped through, refining the lines.
🐰 With each leap and bound, events renamed with care,
A tale of clarity, in bytes, we now share."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (2f07dd2) 81.04% compared to head (ef1858d) 81.02%. Report is 3 commits behind head on master.

:exclamation: Current head ef1858d differs from pull request most recent head c298114. Consider uploading reports for the commit c298114 to get more accurate results

Files	Patch %	Lines
x/profiles/ibc_module.go	0.00%	12 Missing :warning:
x/posts/types/models.go	0.00%	6 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1295 +/- ## ========================================== - Coverage 81.04% 81.02% -0.02% ========================================== Files 218 218 Lines 17880 17898 +18 ========================================== + Hits 14490 14502 +12 - Misses 2778 2784 +6 Partials 612 612 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dadamu commented 5 months ago

Overall looks good to me, just some naming unconsistency.

desmos-labs / desmos