Closed ryuash closed 4 years ago
Merging #126 into master will increase coverage by
0.47%
. The diff coverage is84.17%
.
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 61.29% 61.76% +0.47%
==========================================
Files 262 266 +4
Lines 6601 6711 +110
==========================================
+ Hits 4046 4145 +99
- Misses 2555 2566 +11
Impacted Files | Coverage Δ | |
---|---|---|
lib/sources/posts/local/local_posts_source.dart | 86.66% <0.00%> (-1.49%) |
:arrow_down: |
lib/ui/widgets/post_content_image_item/index.dart | 0.00% <ø> (ø) |
|
lib/ui/widgets/post_images_previewer/index.dart | 18.18% <ø> (ø) |
|
...opup_report/widgets/popup_report_option/index.dart | 100.00% <ø> (ø) |
|
lib/ui/widgets/posts_list_item/index.dart | 66.66% <ø> (+3.03%) |
:arrow_up: |
lib/ui/localization/messages/index.dart | 60.89% <66.66%> (-0.47%) |
:arrow_down: |
...n/widgets/posts_list/widgets/error_post/index.dart | 78.37% <78.37%> (ø) |
|
...on/widgets/dialogs/widgets/popup_report/index.dart | 94.44% <81.25%> (-1.86%) |
:arrow_down: |
lib/ui/blocs/posts_list/posts_list_bloc.dart | 57.14% <83.33%> (+6.67%) |
:arrow_up: |
lib/usecases/posts/usecase_delete_post.dart | 83.33% <83.33%> (ø) |
|
... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2bc80f9...41ee086. Read the comment docs.
Hey I didn't actually remove the red backgrounds yet..Let me make a quick PR to handle that
Description
closes #55
Got distracted and made small ui changes to report popup screen
Removed
ERRORED
post statuses to be retried unless the user asks for itadded
retry
ordelete
errored postsComments:
I had trouble trying to do a full end to end scenario with this but i made tests on each layer. I wasn't sure if we still wanted the Errored Post to show up in ListPosts with the red background. Let me know and i can change it in this PR
Checklist
CHANGELOG.md
file.Files changed
in the Github PR explorer.