search

desmos-labs / mooncake

The first decentralized social app based on Desmos
MIT License
46 stars 14 forks source link

Profile saving loading bar never stops #26

Closed RiccardoM closed 4 years ago

RiccardoM commented 4 years ago
Originally reported by @lauranori inside the internal Slack. ## Generic information - OS name and version: `iOS 13.5.1` - Application build code: `4004` - Network type (mobile/Wi-Fi): `mobile` and `Wi-Fi` ## Bug description After saving the profile, the loading bar never stops spinning. ## Steps to reproduce 1. Edit the profile information. 2. Save the profile. ## Expected behavior The profile should be saved and the loading bar should stop spinning.
RiccardoM commented 4 years ago

Cannot reproduce. 

Version: 0.4.0+04010
Device: Google Nexus 5X / Xiaomi Mi 9T
OS: Android 10.0
RiccardoM commented 4 years ago

Apparently, this is a bug caused by Desmos not handling correctly the edit of a profile picture without a moniker. As @bragaz said on Slack (internal message):

checking on the explorer there’s an internal error when she tries to do that

I think there’s some missing checks on a nil pointer

Oh, they are two different problems I think. Could you guys try to:

  1. Create a new account
  2. Edit the profile adding only the profilePic besides moniker
  3. Save the Profile

What should be done Mooncake-side is improving how errors are managed inside the screen that allows you to edit the account. Currently, there is no error management and the loading bar keeps spinning instead of stopping and displaying an error.

We should fix this by making so that if an error is raised during the saving, it is shown properly to the user.