Edit or remove the messages not committed

desmos-labs / mooncake

The first decentralized social app based on Desmos

MIT License

46 stars 14 forks source link

Edit or remove the messages not committed #55

Closed kwunyeung closed 4 years ago

kwunyeung commented 4 years ago

When there is one failed message, all messages be trying to broadcast after it will not be committed. It is because all the messages will be grouped together and sent as a single transaction. The ValidateBasic will already blocked the tx being delivered. This can be solved if we can remove any failed messages or edit the message to become the correct format.

ryuash commented 4 years ago

@kwunyeung @RiccardoM What do you guys think if we...

Grab all the failed posts locally and list them at the top of the posts list so that we let the user know this is first priority (I don't know if that's what we currently do)
When we sync the post we won't grabbed the error ones.
Instead, we can have a retry, delete button (ok anedit too but I would prioritize the retry and delete) that would allow the user to reset the post status for syncing or remove it locally.

kwunyeung commented 4 years ago

This sounds a good approach. This is similar to the users Flow of Instagram. They have a small preview of failed post and as users to retry or delete.

They also put those not posted post in Draft. When you create a new post, it shows those drafts.

RiccardoM commented 4 years ago

I approve your proposal @ryuash