desmos-labs / mooncake

The first decentralized social app based on Desmos
MIT License
46 stars 14 forks source link

Fix/poll display 88 #91

Closed ryuash closed 4 years ago

ryuash commented 4 years ago

Description

fixes #88

Checklist

ryuash commented 4 years ago

Wasn't sure if i needed to update changelog

codecov[bot] commented 4 years ago

Codecov Report

Merging #91 into master will increase coverage by 0.06%. The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   17.72%   17.79%   +0.06%     
==========================================
  Files         258      258              
  Lines        6290     6295       +5     
==========================================
+ Hits         1115     1120       +5     
  Misses       5175     5175              
Impacted Files Coverage Δ
lib/sources/posts/local/local_posts_source.dart 90.15% <86.36%> (+0.38%) :arrow_up:
lib/repositories/posts/posts_repository_impl.dart 94.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51be504...3434e11. Read the comment docs.

RiccardoM commented 4 years ago

Wasn't sure if i needed to update changelog

I think we can add a line under the Bug Fixes category that reads:

Fixed a bug that causes a wrong visualization of a post details

I usually add a changelog entry only when I change something or fix a bug that was present on the previous public beta, and so external users can notice has been changed.