desmos-labs / mooncake

The first decentralized social app based on Desmos
MIT License
46 stars 14 forks source link

Fix/misleading poll 86 #95

Closed ryuash closed 4 years ago

ryuash commented 4 years ago

Description

fixes #86 Removed poll question, instead we will use the status and fixed up some styling to match wireframe

Screen Shot 2020-07-24 at 11 16 03 AM
Screen Shot 2020-07-24 at 11 16 03 AM

Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.11%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   17.79%   17.67%   -0.12%     
==========================================
  Files         258      258              
  Lines        6295     6336      +41     
==========================================
  Hits         1120     1120              
- Misses       5175     5216      +41     
Impacted Files Coverage Δ
...reate_screen/blocs/post_input/post_input_bloc.dart 0.00% <0.00%> (ø)
...screen/blocs/post_input/post_input_event_poll.dart 0.00% <ø> (ø)
...eate_screen/blocs/post_input/post_input_state.dart 0.00% <0.00%> (ø)
..._screen/widgets/create_post_actions_bar/index.dart 0.00% <0.00%> (ø)
..._post_content/widgets/post_poll_creator/index.dart 0.00% <0.00%> (ø)
...ontent/widgets/post_poll_creator/utils/common.dart 0.00% <0.00%> (ø)
...poll_creator/widgets/poll_option_editor/index.dart 0.00% <0.00%> (ø)
...ll_creator/widgets/poll_question_editor/index.dart 0.00% <ø> (ø)
...creen/widgets/post_details_main_content/index.dart 0.00% <0.00%> (ø)
...ount_edit_screen/blocs/edit/edit_account_bloc.dart 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09b74c9...2e0ce5c. Read the comment docs.

ryuash commented 4 years ago

@RiccardoM so i only updated the visuals for the poll. Should i also remove the poll.question key from the entities and whats being sent to the chain? Would it break any backend code?

RiccardoM commented 4 years ago

@ryuash I would advise against removing the question key from the PollData to be honest. The backend is based on Desmos, which requires that key when sending a poll as you can see from the documentation.

ryuash commented 4 years ago

@RiccardoM

Screen Shot 2020-07-27 at 9 48 55 AM Screen Shot 2020-07-27 at 9 49 06 AM