search

desmosinc / mathquill

Magic textboxes where you can type math as easily as writing!
mathquill.com
137 stars 42 forks source link

Fix \textcolor quoting issue #235

Closed jackschmidt closed 2 years ago

jackschmidt commented 2 years ago

Instead of setting the css color to the argument passed to \textcolor, the code was setting it to the word "color". Unquote it a bit to give working behavior. The typo came from the jquery code which passed everything as a single string, versus the new style which uses javascript properties, and thus has one less layer of quoting.

jwmerrill commented 2 years ago

Great catch. Thank you!

Before we merge this, would you mind signing MathQuill's Contributor License Agreement? You can do that here: https://cla-assistant.io/mathquill/mathquill

jackschmidt commented 2 years ago

I believe this is now done (the page now reports "You have agreed to the CLA for mathquill/mathquill")

Insofar as my code contribution is copyrightable, I own that copyright, I grant the MathQuill maintainers a nonexclusive irrevocable license to use the code in any way, and I have the right to make that grant.