deso-protocol / core

DeSo core node
https://docs.deso.org
MIT License
325 stars 110 forks source link

Fix signature serialization in MsgDeSoTxn (broken by go1.22 upgrade) #1250

Closed diamondhands0 closed 3 months ago

diamondhands0 commented 3 months ago

With the upgrade to go1.22 we had to upgrade our crypto libraries to use ecdsa2.Signature rather than btcec.Signature. This wouldn't have been an issue except for the fact that the former makes its members private, which breaks the JSON serialization of signatures, which is unfortunately used in a lot of places. To fix this, we wrote a custom JSON serializer/deserializer for DeSoSignature that fixes the issue.