deso-protocol / core

DeSo core node
https://docs.deso.org
MIT License
326 stars 108 forks source link

coin price bug #29

Closed dgsus closed 2 years ago

dgsus commented 3 years ago

team,

the salomon bug has been fixed however i'm still seeing accounts that their price are not making sense.

https://github.com/bitclout/core/blob/2cbd77da61109303f3f961c227a414ab063a74d6/lib/constants.go#L78

It seems the bug is not only happening on buy option but sell too.

Please check https://bitclout.com/u/Petrh -> it seems the bug occurred in the sell option , different from salomon bug. https://bitcloutsignal.com/history/petrh

Also please look at https://bitclout.com/u/speakinglight -> this seems to be like the salomon bug https://bitcloutsignal.com/history/speakinglight

please look at this before we get more users onboarded, since this can be a significant challenge going forward if the creator coins are not always working correctly.

this might be a UI problem and not blockchain, if we go to signalclout we can see their real price.

petrh - should be around 555 usd speakinglight - should be around 268 usd

thanks in advance!

tijno commented 3 years ago

Ive seen this too and also seen some accounts use it as a way to scam investments. I didnt note the account ID but one was a imitation account of a well known account, and had used the bug i think to elevate price.

vinnymeller commented 3 years ago

I'm having this issue too, I want to buy my own coin but the price shows up as being far, far too high. With only 0.0008 coins currently in circulation, 49 bitclout will only get me ~3 creator coins:

image

image

I'd like to buy my coin but I don't want to throw away all my bitclout if I have to go back and sell and suddenly its using the correct bonding curve :x

@tijno you mentioned you saw a fake account use the bug? So it must be reproducible somehow

I stumbled across this on accident.

Not sure if it helps, but my FR has pretty much always been at 100% so I had no coin holders except the 8 diamonds I gave (0.0008 coins exist). I sold all my coins to play the raj lahoti game, and transferred back when done playing. Now when I try to buy I get this

UPDATE:

I went ahead and just tested with some small $ amounts to see if coin price in $ and bitclout and all matched what the UI told me it would image

And in fact, buying a tiny amount of my coin put it up to a 0.05 bitclout coin price, and I received the original amounts back when I sold as well

My questions:

  1. If I buy my token now and this gets fixed in the future, would I lose all my $? e.g. I spend all 49 $clout on my coin and it goes up to ~$4k coin price, bug gets fixed and coin is more like $800 I think. Now I sell and I have a small fraction of my original coins. Is this possible?
  2. Can the bug get fixed for an affected account or is it permanent? Will I have to make a new one to not have this issue?

@maebeam

UPDATE 2: After playing around with buying and selling I realized the bonding curve was getting more and more messed up. Here is what it looks like now after a couple iterations of buying and selling 0.01 bitclout worth of my creator coin image

This seems way more important than the responses to this issue would indicate.

Knowns:

tijno commented 3 years ago

another case here @maebeam @lazynina @diamondhands0

coinprice 16k 0.11 coins in circulation

https://bitclout.com/posts/7905dc372e16dace1ba5f1032c8e1162dd7084041f158f161f61123d8ca31dfa

ghost commented 3 years ago

another case here @maebeam @lazynina @diamondhands0

coinprice 16k 0.11 coins in circulation

https://bitclout.com/posts/7905dc372e16dace1ba5f1032c8e1162dd7084041f158f161f61123d8ca31dfa

2021-06-18 00_02_23-papatya on BitClout

≈ $598.85 Total USD Locked

this money is lost

vinnymeller commented 3 years ago

@drshenn that's strange

for mine, the value is still all there. the bonding curve is just mad broken

I will get the same bitclout out that I put into it if I sell it image

though that doesn't seem to be the case in the issue you posted?

ghost commented 3 years ago

2021-06-17 21_30_12-papatya on BitClout - Opera My money disappeared. Really interesting. I hope the problem will be solved.

maebeam commented 3 years ago

Thanks for investigating this everyone! The core devs are working on a solution. I'll update this issue once we have more information.

ghost commented 3 years ago

Thanks for investigating this everyone! The core devs are working on a solution. I'll update this issue once we have more information.

thank you so much. so can i get my money back? 600 dollars is a lot of money for Turkey.

maebeam commented 3 years ago

The core devs have never seen a case where these trades have resulted in a loss of funds. If you think you lost funds I would suggest emailing node.admin@bitclout.com

ghost commented 3 years ago

The core devs have never seen a case where these trades have resulted in a loss of funds. If you think you lost funds I would suggest emailing node.admin@bitclout.com

My money is lost. All transactions are already on the blockchain. I will send an e-mail but will I get a response?

ghost commented 3 years ago

All the problem happened after these actions. This is a very dangerous bug. After this action, the money disappeared from the account. I tried to get the money with small attempts but it didn't work. Please save my money.

https://explorer.cloutangel.com/address/@papatya

unnamed

@maebeam @lazynina @diamondhands0

ghost commented 3 years ago

The core devs have never seen a case where these trades have resulted in a loss of funds. If you think you lost funds I would suggest emailing node.admin@bitclout.com

I sent an e-mail to this address. But this is also a very important bug. It's not just a circulation error. Money is lost as well.

https://docs.bitclout.com/devs/bug-bounty I also sent a message to the mail at this address. When will you get back to me? I can't use my 3 bitclout right now.

ghost commented 3 years ago

We see the transactions better on this site. https://bitcloutsignal.com/history/papatya 2021-06-22 21_35_05-@BitcloutSignal

Nobody answers my mail. I lost my money for 5 days.

@maebeam @lazynina @diamondhands0

tijno commented 3 years ago

just noting another example here https://bitclout.com/u/biteagle

4.5k coin price with $4.6 locked

tijno commented 3 years ago

Another one

https://bitclout.com/u/speakingLight

20210626-bFilr639

And som others: https://bitclout.com/u/Pegleg https://bitclout.com/u/grenier

ghost commented 3 years ago

I really can't understand. There is a very important bug. But nobody answers. Still no one has replied to my email.

ghost commented 3 years ago

2021-06-26 21_44_04-Pegleg on BitClout This account is also missing $300.

diamondhands0 commented 3 years ago

Hey everyone, just updating here. We're very familiar with this bug, and we refer to it as the Salomon bug, named after @salomon who first triggered it (@speakingLight was also an early user who triggered it). Importantly, because all rankings are done using BitClout locked rather than price, this issue is mainly cosmetic and does not affect any of the core functionality.

If you grep the codebase and commit history for salomon you should see a partial fix from a while ago that significantly decreases one's ability to throw off the price. In particular, it now requires deliberate effort to trigger it, and the price will only be ~10k max in the worst case vs the hundreds of millions we were seeing before.

Again, this does not affect any core functionality since BitClout locked is what's used for all calculations; it just results in a price that is at odds with how much is locked.

I'm leaving this open until it is 100% fixed, but wanted to let everyone know that we're aware of this issue and update with current status.

ghost commented 3 years ago

Hey everyone, just updating here. We're very familiar with this bug, and we refer to it as the Salomon bug, named after @salomon who first triggered it (@speakingLight was also an early user who triggered it). Importantly, because all rankings are done using BitClout locked rather than price, this issue is mainly cosmetic and does not affect any of the core functionality.

If you grep the codebase and commit history for salomon you should see a partial fix from a while ago that significantly decreases one's ability to throw off the price. In particular, it now requires deliberate effort to trigger it, and the price will only be ~10k max in the worst case vs the hundreds of millions we were seeing before.

Again, this does not affect any core functionality since BitClout locked is what's used for all calculations; it just results in a price that is at odds with how much is locked.

I'm leaving this open until it is 100% fixed, but wanted to let everyone know that we're aware of this issue and update with current status.

So you are trying to solve the problem. Just hearing that made me happy. So I can use my money. (I bought creator coin with bitclout. After purchasing, these creator coins were deleted. In the solomon bug, the money was not lost. In my problem, the money is lost. )

I really trust the bitclout project. It is a game changer movement. I even aim to expand this project in my country.

I worked on a blockchain-based social media project for 3-4 years. I want to use my experience here. Due to Covid, medical work is very busy right now. After things get comfortable, I'll create a dev team. I don't want to say much about the project here, but we will revolutionize the Play Store and App Store. (You know, Turkey is a very important country for the mobile application industry. If an application wants to be successful in the Middle East and Balkan markets, the Turkish market has to be involved.) Since we will use the Bitclout infrastructure completely in our projects, we have to rely on the project's blockchain infrastructure. That's why we are afraid of the slightest bug.

ghost commented 3 years ago

https://bitclout.com/posts/e250f57130c494fb112b04d1c47d86c9a6b7df3c039e0921858413879eb4a120?feedTab=Global

@maebeam @lazynina @diamondhands0

How many software developers do you have in your development team? 50? 101? You are very fast. Thank you very much. I knew very well that my money would not go to waste. I know the Bitclout project will revolutionize. We will join this revolution soon. There have already been 8 revolutionaries in my dev team. We will start the projects as soon as possible. We will destroy Twitter and Facebook in Google Play and App Store.

binoyxj commented 3 years ago

Any update on this? I'm personally suffering from this bug since day 1. Heard from @maebeam that this will be addressed along with the NFT feature drop. But since it's such an integral feature and no ETA on the NFT feature launch have me worried.

mvanhalen commented 3 years ago

I have one here https://bitclout.com/u/CreatorCapital?tab=creator-coin account is 15 days old according to https://www.prosperclout.com/u/CreatorCapital?tab=overview

tijno commented 3 years ago

This is as a result of NFTs with 100% Coin Royalty - there's been a few examples last 12 hours or so:

https://bitclout.com/u/100CoinHolderRoyaltyNFTs 20210731-afq59hAg

https://bitclout.com/u/infinityprice 20210731-ydFSQ7dL

https://bitclout.com/u/TestingNFTRoyalty 20210731-JGNNhhVP

speakingLight commented 3 years ago

thank you for the reply, sorry for my public discomfort from experiencing this glitch i appreciate the functionality of the platform and will begin posting again soon i'm just some weird sensitive guy that likes to say things

On Sat, Jul 31, 2021 at 7:24 AM BitClout @Tijn @.***> wrote:

This is as a result of NFTs with 100% Coin Royalty - there's been a few examples last 12 hours or so:

https://bitclout.com/u/100CoinHolderRoyaltyNFTs [image: 20210731-afq59hAg] https://user-images.githubusercontent.com/69529928/127739765-44ad6128-ac6e-48f7-8f1a-3dd59554f889.png

https://bitclout.com/u/infinityprice [image: 20210731-ydFSQ7dL] https://user-images.githubusercontent.com/69529928/127739768-47cc844e-2c16-493f-b4ba-52c7b141bf6d.png

https://bitclout.com/u/TestingNFTRoyalty [image: 20210731-JGNNhhVP] https://user-images.githubusercontent.com/69529928/127739770-2629b749-a192-4d31-9496-1253e6b3533f.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitclout/core/issues/29#issuecomment-890340724, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASPC432USDMUQTQDKUUZZHDT2PTQRANCNFSM46LUOF3Q .

sungkhum commented 3 years ago

Just pinging this - seeing it come up a fair amount on my creator coin listing sites and waiting for a complete fix.

maebeam commented 2 years ago

Hey everyone,

With the addition of NFTs the "coin price" of a profile is not a recommended metric to use. The "total deso locked" in a profile is always reliable and can be used to rank creators.

Since there is no fix for this behavior and the core devs don't have any near term plans to change this behavior I'm going to close this issue. Please let me know if you have any questions / comments / concerns.